Skip to content

magento/magento2#: Replace deprecated addError, addSuccess, addException methods in Magento/Customer/Controller/Account/CreatePost.php#24197

Merged
magento-engcom-team merged 11 commits into
magento:2.3-developfrom
atwixfirster:customer-replace-deprecated-message-func
Oct 22, 2019
Merged

magento/magento2#: Replace deprecated addError, addSuccess, addException methods in Magento/Customer/Controller/Account/CreatePost.php#24197
magento-engcom-team merged 11 commits into
magento:2.3-developfrom
atwixfirster:customer-replace-deprecated-message-func

Conversation

@atwixfirster
Copy link
Copy Markdown
Contributor

@atwixfirster atwixfirster commented Aug 20, 2019 •
edited
Loading

Description (*)

Pull request replaces deprecated addError, addSuccess, addException methods in Magento/Customer/Controller/Account/CreatePost.php of Magento_Customer module:

addError -> addErrorMessage
addSuccess -> addSuccessMessage
addException -> addExceptionMessage

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Thank you!

@atwixfirster
magento/magento2#: Replace deprecated addError, addSuccess, addExcept…
6b42eb2 
…ion methods in Magento_Customer module

addError -> addErrorMessage
addSuccess -> addSuccessMessage
addException -> addExceptionMessage
@m2-assistant
Copy link
Copy Markdown

m2-assistant Bot commented Aug 20, 2019

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Customer Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 20, 2019
@atwixfirster atwixfirster added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner and removed Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 20, 2019
@dmytro-ch dmytro-ch self-requested a review August 20, 2019 06:15
@dmytro-ch dmytro-ch self-assigned this Aug 20, 2019
@atwixfirster
magento/magento2#: Replace deprecated addError, addSuccess, addExcept…
e56a4c7 
…ion methods in Magento_Customer module

Fix. Unit tests
dmytro-ch
dmytro-ch requested changes Aug 20, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atwixfirster , could you please check the failed integration tests.
There is a difference in expected results due to escaped characters after using the new methods.

@atwixfirster
magento/magento2#: Replace deprecated addError, addSuccess, addExcept…
3a04bb7 
…ion methods in Magento_Customer module
@atwixfirster
magento/magento2#: Replace deprecated addError, addSuccess, addExcept…
444fb5c 
…ion methods in Magento_Customer
@atwixfirster
magento/magento2#: Replace deprecated addError, addSuccess, addExcept…
c743624 
…ion methods in Magento_Customer
@atwixfirster
magento/magento2#: Replace deprecated addError, addSuccess, addExcept…
0bf86e6 
…ion methods in Magento_Customer
@atwixfirster
magento/magento2#: Replace deprecated addError, addSuccess, addExcept…
60823ed 
…ion methods in Magento_Customer
@atwixfirster
magento/magento2#: Replace deprecated addError, addSuccess, addExcept…
5b360cb 
…ion methods in Magento/Customer/Controller/Account/CreatePost.php
@atwixfirster
magento/magento2#: Replace deprecated addError, addSuccess, addExcept…
d12a2ab 
…ion methods in Magento/Customer/Controller/Account/CreatePost.php
@atwixfirster
magento/magento2#: Replace deprecated addError, addSuccess, addExcept…
12c738e 
…ion methods in Magento/Customer/Controller/Account/CreatePost.php
@atwixfirster atwixfirster changed the title magento/magento2#: Replace deprecated addError, addSuccess, addException methods in Magento_Customer module magento/magento2#: Replace deprecated addError, addSuccess, addException methods in Magento/Customer/Controller/Account/CreatePost.php Aug 25, 2019
@atwixfirster
magento/magento2#: Replace deprecated addError, addSuccess, addExcept…
dd34452 
…ion methods in Magento/Customer/Controller/Account/CreatePost.php
@atwixfirster
Copy link
Copy Markdown
Contributor Author

atwixfirster commented Aug 28, 2019

@atwixfirster , could you please check the failed integration tests.

done

@dmytro-ch, could you please review?

Thank you!

@edenduong edenduong mentioned this pull request Aug 29, 2019
Merged
4 tasks
@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Area: Frontend labels Aug 29, 2019
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 29, 2019

Hi @dmytro-ch, thank you for the review.
ENGCOM-5730 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch mentioned this pull request Aug 29, 2019
Merged
4 tasks
@engcom-Alfa engcom-Alfa self-assigned this Aug 30, 2019
@engcom-Alfa
Copy link
Copy Markdown
Contributor

engcom-Alfa commented Aug 30, 2019

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Aug 30, 2019
sidolov
sidolov requested changes Oct 1, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@sidolov sidolov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atwixfirster looks like the simple implementation with just messages became a really complex, could you please clarify why we need to use additional templates for simple messages that can be inlined and used in addSuccessMessage method?

@ghost ghost assigned sidolov Oct 1, 2019
@atwixfirster
Copy link
Copy Markdown
Contributor Author

atwixfirster commented Oct 2, 2019 •
edited
Loading

@atwixfirster looks like the simple implementation with just messages became a really complex, could you please clarify why we need to use additional templates for simple messages that can be inlined and used in addSuccessMessage method?

Hi, @sidolov !

I will try to explain on the following example.

Preconditions:

  1. Go to CUSTOMERS > Customer Configuration > Create New Account Options on the back-end side
  2. Set option Require Emails Confirmation = Yes

Steps to reproduce:

  1. Register a new customer on FE side
  2. With addComplexSuccessMessage you will get:

24197_01

  1. With addSuccessMessage output result will be a slightly different:

24197_02

Thank you!

@atwixfirster
Copy link
Copy Markdown
Contributor Author

atwixfirster commented Oct 3, 2019 •
edited
Loading

@atwixfirster looks like the simple implementation with just messages became a really complex,...

@sidolov , you can see the same implementations in the Magento_Wishlist module:

Thank you!

magento-engcom-team pushed a commit that referenced this pull request Oct 22, 2019
@VladimirZaets
ENGCOM-5730: magento/magento2#: Replace deprecated addError, addSucce…
df9c31e 
…ss, addException methods in Magento/Customer/Controller/Account/CreatePost.php #24197
@magento-engcom-team magento-engcom-team merged commit dd34452 into magento:2.3-develop Oct 22, 2019
@m2-assistant
Copy link
Copy Markdown

m2-assistant Bot commented Oct 22, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidolov sidolov sidolov requested changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@sidolov sidolov

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels

Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Component: Customer Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@atwixfirster @magento-engcom-team @engcom-Alfa @sidolov @dmytro-ch @engcom-Foxtrot